Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds flask unittests #53

Closed
wants to merge 2 commits into from
Closed

Conversation

chaps
Copy link
Contributor

@chaps chaps commented Oct 9, 2019

Adds some test cases for requests on different endpoints.

  • If endpoints are not requested in a particular order, some session variables are not being set.
  • test_check_code states that it returns a JSON object when it currently returns a list of values that contains the expected JSON object as the first element.

These test cases can serve in order to add coverage for the use cases and maybe open them as issues:

  • initialize the session dict key values if not set, in order to avoid these KeyErrors raised exceptions.
  • make sure check_code returns the documented value

@ethanchewy
Copy link
Owner

Thanks for the great work - @dgmouris was also working on this: #28

I'll try to figure out a way to combine both of your work together.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants